mirror of
https://github.com/anthropics/claude-code-action.git
synced 2026-08-22 11:28:55 +08:00
fix: allow # in branch names for PR checkout and base restore (#1167)
`validateBranchName` used a strict whitelist that excluded `#`, causing the action to fail on PRs from branches like `put-back-arm64-#2` with "Invalid branch name" — even though the branch already exists in git and `#` is permitted by git-check-ref-format. The validation was designed to prevent command injection. However, every git call in the action uses `execFileSync`, which bypasses the shell entirely and passes arguments directly to the kernel's execve. There is no shell to interpret `#` as a metacharacter, so the strict whitelist was over-blocking valid names with no security benefit. Add `#` to the whitelist pattern, and update the JSDoc and error message to reflect the allowed character set. Fixes #1137. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Sonnet 4.6
parent
d5db8208f9
commit
b15d4751a6
@@ -36,6 +36,13 @@ describe("validateBranchName", () => {
|
||||
expect(() => validateBranchName("refs/heads/main")).not.toThrow();
|
||||
expect(() => validateBranchName("bugfix/JIRA-1234")).not.toThrow();
|
||||
});
|
||||
|
||||
it("should accept branch names containing # (git-valid, common in issue-linked branches)", () => {
|
||||
// Reported in #1137: branches like "put-back-arm64-#2" were rejected
|
||||
expect(() => validateBranchName("put-back-arm64-#2")).not.toThrow();
|
||||
expect(() => validateBranchName("feature/#123-description")).not.toThrow();
|
||||
expect(() => validateBranchName("fix/issue-#42")).not.toThrow();
|
||||
});
|
||||
});
|
||||
|
||||
describe("command injection attempts", () => {
|
||||
|
||||
Reference in New Issue
Block a user