actions/claude-code-action
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use correct fallback type for reviewData in fetcher (#1034)

Browse Source 
The reviewData variable is typed as `{ nodes: GitHubReview[] } | null`,
but the fallback value was `[]` (a plain array). When
`pullRequest.reviews` is null/undefined, `reviewData` becomes `[]`,
causing `reviewData.nodes` to return `undefined` instead of `[]`.

This leads to silent failures in downstream code that iterates over
`reviewData.nodes`, such as `filterReviewsToTriggerTime` and
`filterCommentsByActor`.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Maxwell Calkin 2026-04-04 23:12:05 -04:00 committed by GitHub
parent 27f549ae64
commit 21b0f0f9aa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/github/data/fetcher.ts
View File

@ -299,7 +299,7 @@ export async function fetchGitHubData({
includeCommentsByActor,
excludeCommentsByActor,
);
reviewData = pullRequest.reviews || [];
reviewData = pullRequest.reviews || { nodes: [] };
console.log(`Successfully fetched PR #${prNumber} data`);
} else {