actions/claude-code-action
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Include issue_comment in event-gated settingSources default

Browse Source 
🏠 Remote-Dev: homespace
This commit is contained in:
Octavian Guzu 2026-04-23 17:24:56 +00:00
parent a551ae4682
commit 044a1036f6
No known key found for this signature in database
4 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
base-action/README.md
View File

@ -112,6 +112,8 @@ Add the following to your workflow file:
\*\*`show_full_output` is automatically enabled when GitHub Actions debug mode is active. See [security documentation](../docs/security.md#️-full-output-security-warning) for important security considerations.
`setting_sources` defaults to `user,project,local` for most events. Under `pull_request_target`, `workflow_run`, and `issue_comment` it defaults to `user` only; set it explicitly if you want project/local settings to load for those events.
## Outputs
| Output | Description |

2
base-action/action.yml
View File

@ -19,7 +19,7 @@ inputs:
required: false
default: ""
setting_sources:
description: "Comma-separated list of setting sources to load (user, project, local). Defaults to 'user,project,local'; under pull_request_target/workflow_run, defaults to 'user' only. Project/local settings additively merge permissions with allowed_tools — set explicitly to control which sources load."
description: "Comma-separated list of setting sources to load (user, project, local). Defaults to 'user,project,local'; under pull_request_target/workflow_run/issue_comment, defaults to 'user' only. Project/local settings additively merge permissions with allowed_tools — set explicitly to control which sources load."
required: false
default: ""

9
base-action/src/parse-sdk-options.ts
View File

@ -274,16 +274,17 @@ export function parseSdkOptions(options: ClaudeOptions): ParsedSdkOptions {
// Setting sources precedence: direct input > --setting-sources in claude_args > default.
// The default is supplied by the caller (the wrapper action passes
// ["user","project","local"]); base-action applies an event-gated default of ["user"]
// under pull_request_target/workflow_run and ["user","project","local"] otherwise.
// Both action.yml files leave the YAML default empty so that --setting-sources in
// claude_args is reachable when the input is not set.
// under pull_request_target/workflow_run/issue_comment and ["user","project","local"]
// otherwise. Both action.yml files leave the YAML default empty so that
// --setting-sources in claude_args is reachable when the input is not set.
settingSources: (options.settingSources
? options.settingSources.split(",").map((s) => s.trim())
: extraArgs["setting-sources"]
? extraArgs["setting-sources"].split(",").map((s) => s.trim())
: (options.defaultSettingSources ??
(process.env.GITHUB_EVENT_NAME === "pull_request_target" ||
process.env.GITHUB_EVENT_NAME === "workflow_run"
process.env.GITHUB_EVENT_NAME === "workflow_run" ||
process.env.GITHUB_EVENT_NAME === "issue_comment"
? ["user"]
: ["user", "project", "local"]))) as SdkOptions["settingSources"],
};

7
base-action/test/parse-sdk-options.test.ts
View File

@ -458,6 +458,13 @@ describe("parseSdkOptions", () => {
expect(result.sdkOptions.settingSources).toEqual(["user"]);
});
test("should default to ['user'] under issue_comment", () => {
process.env.GITHUB_EVENT_NAME = "issue_comment";
const result = parseSdkOptions({});
expect(result.sdkOptions.settingSources).toEqual(["user"]);
});
test("should use direct settingSources input when provided", () => {
const options: ClaudeOptions = {
settingSources: "user,project,local",